Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Errkit migration 8.4 migrate remaining piece of pkg/kando, pkg/kanx, pkg.ksprig to errkit #3257

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Nov 26, 2024

Change Overview

Migrate pkg/kando, pkg/kanx and pkg.ksprig to errkit.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@e-sumin e-sumin force-pushed the errkit_migration_8_4_kando branch from f6401e4 to 9f6590d Compare November 26, 2024 10:59
Copy link
Contributor

@r4rajat r4rajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hairyhum hairyhum added the kueue label Dec 3, 2024
@mergify mergify bot merged commit 2fed698 into master Dec 3, 2024
23 checks passed
@mergify mergify bot deleted the errkit_migration_8_4_kando branch December 3, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants